Croogo Croogo → 1.4.2

Comments and changes to this ticket

• 

  Nitish Dhar May 17th, 2012 @ 08:19 AM

  Also,

  heads up, I was wrong about reproducing this is easy. This happens once in a while. I fail to connect this to anything related to the code. I mean how can this happen just sometimes. The only thing, I can relate this is to some cache problem.

  Anyways, have a look

• 

  Nitish Dhar May 17th, 2012 @ 08:56 AM

  Well, looks like, if we don't do any change also after the error comes, waiting for like 20 seconds fixes the issue. The more I word around this, the more weird it gets...

• 

  Rachman Chavik May 17th, 2012 @ 10:57 AM

  • State changed from “new” to “open”
  • Assigned user set to “Rachman Chavik”
  • Milestone set to “1.4.2”
  • Milestone order changed from “111” to “0”

  Okay.

  This one I can reproduce :).

• 

  Rachman Chavik May 17th, 2012 @ 11:43 AM

  Can you apply this and test:

  diff --git a/Config/croogo_bootstrap.php b/Config/croogo_bootstrap.php
  index f4a3cfe..0002219 100755
  --- a/Config/croogo_bootstrap.php
  +++ b/Config/croogo_bootstrap.php
  @@ -67,6 +67,15 @@
      Configure::write('Config.language', Configure::read('Site.locale'));
   
   /**
  + * Setup Helper path (CustomHelper) from themes
  + */
  +   if ($theme = Configure::read('Site.theme')) {
  +       App::build(array(
  +           'View/Helper' => array(App::themePath($theme) . 'Helper' . DS),
  +       ));
  +   }
  +
  +/**
    * Plugins
    */
      $aclPlugin = Configure::read('Site.acl_plugin');
  diff --git a/Controller/Component/CroogoComponent.php b/Controller/Component/CroogoComponent.php
  index a788891..49b9534 100644
  --- a/Controller/Component/CroogoComponent.php
  +++ b/Controller/Component/CroogoComponent.php
  @@ -466,14 +466,6 @@ class CroogoComponent extends Component {
          $this->controller->set('vocabularies_for_layout', $this->vocabularies_for_layout);
          $this->controller->set('types_for_layout', $this->types_for_layout);
          $this->controller->set('nodes_for_layout', $this->nodes_for_layout);
  -
  -       if ($controller->theme) {
  -           //$helperPaths = Configure::read('helperPaths');
  -           //array_unshift($helperPaths, APP.'views'.DS.'themed'.DS.$controller->theme.DS.'helpers'.DS);
  -           //Configure::write('helperPaths', $helperPaths);
  -
  -           App::build(array('View/Helper' => array(APP . 'View' . DS . 'Themed' . DS . $controller->theme . DS . 'Helper' . DS)));
  -       }
      }
   
   /**
  

• 

  Nitish Dhar May 17th, 2012 @ 12:17 PM

  Hey Rachman,

  I have no idea how to apply the above.. Do I need to use git or something ?

• 

  Rachman Chavik May 17th, 2012 @ 12:25 PM

  Hm..

  That diff (patch above basically moves some lines (with some modification) from CroogoComponent to Config/croogo_bootstrap.php

  You can do it manually:

  • Delete the line 470-476 in Controller/Component/CroogoComponent.php

  • Manually add the following after the Locale block in Config/croogo_bootstrap.php

  /**
   * Setup Helper path (CustomHelper) from themes
   */
      if ($theme = Configure::read('Site.theme')) {
          App::build(array(
              'View/Helper' => array(App::themePath($theme) . 'Helper' . DS),
          ));
      }
  

  You could also install git since it then would be easier to pass patch files around.

  Ah, forgot to say, if you already have git, apply the diff above by saving it into a file, eg: patch.diff.
  Then using git: git apply patch.diff

• 

  Nitish Dhar May 17th, 2012 @ 12:31 PM

  Hey, I have git. Just didn't know we can pass patch files to a repo.

  Thanks, will try this and update you.

• 

  Rachman Chavik May 17th, 2012 @ 02:38 PM

  Let me know if this fixes the problem so I could commit to main repo.

• 

  Nitish Dhar May 17th, 2012 @ 02:40 PM

  Hey,

  I am out right now.. Will do this in like 4 - 5 hrs & update you.

  Thanks

• 

  Nitish Dhar May 17th, 2012 @ 02:54 PM

  Hey,

  Going out plans cancelled :) I tested, it works like a charm :) Thanks Rachman :)

• 

  Rachman Chavik May 17th, 2012 @ 03:02 PM

  awesome. i will commit this to main repo soon.

  now only the layout/helper error to track down.

• 

  Nitish Dhar May 18th, 2012 @ 02:03 AM

  Hey any chances this can come in croogo 1.3.5 ?

• 

  Rachman Chavik May 18th, 2012 @ 10:12 AM

  • State changed from “open” to “resolved”

  (from [4b84c95064a4ada25863f9c7ef2c96c8a66a3c4e]) setup helper path during bootstrap

  closes #254
  https://github.com/croogo/croogo/commit/4b84c95064a4ada25863f9c7ef2...